2 Commits

Author SHA1 Message Date
james d18a828195 chore: Release zfsbackup version 0.4.1
Release / release (push) Successful in 1m51s
2026-05-09 14:23:50 +02:00
james a0585764cf Add send completed when reading finishes 2026-05-07 13:42:53 +02:00
7 changed files with 40 additions and 17 deletions
Generated
+1 -1
View File
@@ -435,7 +435,7 @@ dependencies = [
[[package]]
name = "zfsbackup"
version = "0.4.0"
version = "0.4.1"
dependencies = [
"chrono",
"clap",
+1 -1
View File
@@ -1,6 +1,6 @@
[package]
name = "zfsbackup"
version = "0.4.0"
version = "0.4.1"
edition = "2024"
publish = false
+12 -7
View File
@@ -67,15 +67,26 @@ pub fn exec_pipe(
let send_stdout = send_process.stdout.take().unwrap();
let mut receive_stdin = receive_process.stdin.take().unwrap();
{
let mut reader: Box<dyn Read> = Box::new(send_stdout);
for filter in filters {
reader = filter.filter(reader);
}
std::io::copy(&mut reader, &mut receive_stdin).map_err(|e| e.to_string())?;
}
let receive_status = receive_process.wait().map_err(|e| e.to_string())?;
// The send process will typically finish first. If it failed, terminate the
// receiver.
let send_status = send_process.wait().map_err(|e| e.to_string())?;
if !send_status.success() {
receive_process.kill().ok();
return Err(format!(
"Send command {:?} failed with status {}",
source, send_status
));
}
let receive_status = receive_process.wait().map_err(|e| e.to_string())?;
if !receive_status.success() {
send_process.kill().ok();
return Err(format!(
@@ -83,11 +94,5 @@ pub fn exec_pipe(
dest, receive_status
));
}
if !send_status.success() {
return Err(format!(
"Send command {:?} failed with status {}",
source, send_status
));
}
Ok(())
}
+8
View File
@@ -29,6 +29,14 @@ impl<R: Read> Read for ByteCountReader<R> {
}
}
impl<R: Read> Drop for ByteCountReader<R> {
fn drop(&mut self) {
self.sender
.send(BackupEvent::SendCompleted(self.bytes))
.ok();
}
}
impl<R: Read> ByteCountReader<R> {
fn new(inner: R, sender: Sender<BackupEvent>, total: Option<u64>) -> Self {
Self {
+3
View File
@@ -43,6 +43,9 @@ impl super::Progressor for Progressor {
println!("Deleted snapshot: {}", name);
}
BackupEvent::BytesTransferred { .. } => {}
BackupEvent::SendCompleted(bytes) => {
println!("Send completed: {} bytes", bytes);
}
BackupEvent::DatasetCompleted(name) => {
println!("Completed backup of dataset: {}", name);
self.estimated_size = 0;
+2 -1
View File
@@ -16,7 +16,7 @@ fn human_bytes(bytes: f64) -> String {
a /= 1024.0;
i += 1;
}
format!("{:.2} {:2}", a, units[i])
format!("{:.2} {}", a, units[i])
}
fn format_eta(seconds: f64) -> String {
@@ -47,6 +47,7 @@ pub enum BackupEvent {
bytes: u64,
estimated_total: Option<u64>,
},
SendCompleted(u64),
DatasetCompleted(String),
DryrunCompleted(String),
}
+8 -2
View File
@@ -89,11 +89,17 @@ impl super::Progressor for Progressor {
}
std::io::stdout().flush().ok();
}
BackupEvent::SendCompleted(bytes) => {
println!(
"\x1b[2KSend completed at {}, awaiting receive completion",
human_bytes(bytes as f64)
);
}
BackupEvent::DatasetCompleted(name) => {
println!("Completed backup of dataset: {}", name);
println!("\x1b[2KCompleted backup of dataset: {}", name);
}
BackupEvent::DryrunCompleted(name) => {
println!("Completed dry run backup of dataset: {}", name);
println!("\x1b[2KCompleted dry run backup of dataset: {}", name);
}
}
}